Payday and Missing Credit

[madpeople]

Code: Select all

int startMoney;     // the ammount of money we are meant to be sharing out
int players;        // the number of players on the team
Player [] player;    // an array of players on the team
int moneyToGive = startMoney/players; //how much each player gets

for(int i = 0; i< players;i++){
    player[i].giveMoney(moneyToGive);
    startMoney-= moneyToGive;
}

player[0].giveMoney(startMoney); //give the comm what is left (player[0] is the comm)

...

[TurkeyXIII]

Code: Select all

            m_rgMoney[sideID] -= delta * np;

It looks like the game tracks how much the team is paid each time.

A quick test reveals that extra money not paid due to rounding error stays in the budget and is given out in later paychecks when there's enough to go around.

So the bug is not so much missing credits as delayed credits.

Code: Select all

void CFSMission::DoPayday(IsideIGC* pside)
{
    SideID  sideID = pside->GetObjectID();

    int np = GetCountOfPlayers(pside, true);
    if (np != 0)
    {
        int delta = m_rgMoney[sideID] / np;
        if (delta > 0)
        {
            BEGIN_PFM_CREATE(g.fm, pfmPayday, S, PAYDAY)
            END_PFM_CREATE
            pfmPayday->dMoney = Money(delta);
            g.fm.SendMessages(CFSSide::FromIGC(pside)->GetGroup(), FM_GUARANTEED, FM_FLUSH);

            m_rgMoney[sideID] -= delta * np;

            const ShipListIGC * plistShip = pside->GetShips();
            for(ShipLinkIGC * plinkShip = plistShip->first(); plinkShip; plinkShip = plinkShip->next())
            {
                CFSShip * pfsShip = (CFSShip *) plinkShip->data()->GetPrivateData();
                if (pfsShip->IsPlayer())
                {
                    CFSPlayer*  pfsDonate = pfsShip->GetPlayer()->GetAutoDonate();
                    if (pfsDonate)
                        pfsDonate->SetMoney(pfsDonate->GetMoney() + delta);
                    else
                        pfsShip->SetMoney(pfsShip->GetMoney() + delta);
                }
                if (pfsShip->IsCommander()) //Or whatever designates the commander's ship
                {
                    pfsShip->SetMoney(pfsShip->GetMoney() + m_rgMoney[sideID]);
                    m_rgMoney[sideID] = 0;
                }
            }
        }
    }
}

That might add the surplus to the comm's wallet, but there's probably a better way to include it in the donations.

[Gleipnir]

The missing credits are taxes owed to his royal magnificence, the illustrious Overlord Pook.

[pkk]

After looking into code and wasting a few of Imagos hours, I found out that there will be no missing credits...

Credits which will not given out on current payday, will be used for next payday.

Fixing the "problem" gets more complicated, the deeper you look into code.

PS:
Payday uses the same function like minerloads and starting money.

[Dogbones]

QUOTE (TurkeyXIII @ Nov 14 2008, 06:06 AM) A quick test reveals that extra money not paid due to rounding error stays in the budget and is given out in later paychecks when there's enough to go around.

So the bug is not so much missing credits as delayed credits.

[Andon]

It's a conspiracy!

[MrChaos]

*jingles a big bag o'credits*

why do you think we named it Solap