Payday and Missing Credit

[TurkeyXIII]

Or just give it all to the investor in the first place? If you want stopping donating to still be an option, the check for that should be made before the cash is split, not after.

[Psychosis]

QUOTE (Ramaglor @ Oct 1 2008, 06:58 PM) The fudging only goes one way...... "int" always rounds down

so add on $4to starting money

[pkk]

QUOTE (Psychosis @ Oct 3 2008, 12:45 AM) so add on $4to starting money

+4 doesn't help. /doh.gif" style="vertical-align:middle" emoid=":doh:" border="0" alt="doh.gif" />

Just calculate it with eleven players, still missing credits. /wink.gif" style="vertical-align:middle" emoid=";)" border="0" alt="wink.gif" />

[Ramaglor]

why not give the commander the modulus of the division?


*would someone please move this to code bugs and suggestions?*

[Clay_Pigeon]

change

int delta = m_rgMoney[sideID] / np;

to

int delta = m_rgMoney[sideID] / np +1;

?

Team sizes will occasionally result in a slightly larger payday, but I don't think it's enough to worry about, especially since now we can have slightly smaller paydays.

[doofus]

QUOTE (Ramaglor @ Oct 3 2008, 12:58 AM) why not give the commander the modulus of the division?

+1

[Raveen]

What about:

int delta = (m_rgMoney[sideID] / np) + 0.5;

[Vlymoxyd]

I think a logical way would be:

1:Split the money like now.

2: Add the Total money received by each players of the team and substract it from the total money that the team should have received

3: give the reminder to the comm

I don't see why we should bother giving extra cash to the teams when it's so easy to give them exactly what they should receive.

I'm actually pretty sure there are probably much easier way what than what I suggested without ending up with wrong results.

[pkk]

IMO this will fix the bug:

Code: Select all

void CFSMission::DoPayday(IsideIGC* pside)
{
    SideID  sideID = pside->GetObjectID();

    int np = GetCountOfPlayers(pside, true);
    if (np != 0)
    {
        // pkk: delta is now double
        double ddelta = double(m_rgMoney[sideID]) / double(np);
        int delta = int(ddelta);
        if (delta > 0.0)
        {
            BEGIN_PFM_CREATE(g.fm, pfmPayday, S, PAYDAY)
            END_PFM_CREATE
            pfmPayday->dMoney = Money(delta);
            g.fm.SendMessages(CFSSide::FromIGC(pside)->GetGroup(), FM_GUARANTEED, FM_FLUSH);

            // pkk: convert double back to int
            m_rgMoney[sideID] -= int(ddelta * double(np));

            const ShipListIGC * plistShip = pside->GetShips();
            for(ShipLinkIGC * plinkShip = plistShip->first(); plinkShip; plinkShip = plinkShip->next())
            {
                CFSShip * pfsShip = (CFSShip *) plinkShip->data()->GetPrivateData();
                if (pfsShip->IsPlayer())
                {
                    CFSPlayer*  pfsDonate = pfsShip->GetPlayer()->GetAutoDonate();
                    if (pfsDonate)
                        pfsDonate->SetMoney(pfsDonate->GetMoney() + delta);
                    else
                        pfsShip->SetMoney(pfsShip->GetMoney() + delta);
                }
            }
        }
    }
}

Maybe I'm wrong, my C/C++ skills suck.

[cashto]

It won't work. "double z = double(x) / double(y); int zz = int(z);" will give identical results as "int zz = x / y;"

I like vly's idea. Bump the comm's payday by "m_rgMoney[sideID] - delta * np".

Also, if you want a division x / y that always rounds up (for positive x, y), you may consider (x + y - 1) / x.