Commander QoL

A place to post suggestions for new features, new bugs, and comments about the existing code.
Post Reply
Bunnywabbit
Posts: 965
Joined: Sun May 15, 2005 7:00 am
Location: Amsterdam, the Netherlands

Post by Bunnywabbit »

I put this in discord already, which on reflection seems like a surefire way to never ever see it again.

anyway:
I have a commander QoL suggestion:
It's to simply move the investment pane to the side of the screen, rather than the center where it's blocking all view of the action. Given that many people use widescreen monitors now, the screen real estate is there for both having the investment pane opened and being able to see what's going on while you contemplate your buys.

The change involves a single line in dialog.mdl, line 5376:

current:

Code: Select all

(MergedInvestmentsPaneImage, SideCenter, Point(-192, 2000), Point(-192, -265), .5, ofInvestment, false),
new:

Code: Select all

 (MergedInvestmentsPaneImage, SideRight, Point(10, -265), Point(-490, -265), .2, ofInvestment, false),
this way the f5 pane appears from the right and winds up over the f4 inventory menu, respecting the same screen margins and whatnot. It's pretty clean.
I also made the transition a bit quicker.

1920x1080
1280x1024
it gets a little wonky at 1024x768, partly overlapping inventory and command menu. May have to place it a bit higher in release.

what do you guys think?
Last edited by Bunnywabbit on Tue Oct 03, 2017 9:02 am, edited 1 time in total.
ImageImage current version r158 new beta as of jan 23 2012
vogue
Posts: 1971
Joined: Sat Mar 27, 2010 3:28 am

Post by vogue »

I like it a lot. I’ve always wondered why it came down the middle.
phoenix1 wrote:QUOTE (phoenix1 @ May 5 2013, 08:35 PM) Vogue is clearly #1 and commanding against him feels like commanding against Spideycw at times... though he lacks that little bit of "I don't care who's on my team or what the factions are, it's going to be a stomp anyways" that Spidey managed to pull off in his heyday.
Xynth
Posts: 224
Joined: Mon Oct 05, 2009 3:03 pm
Location: St. Louis

Post by Xynth »

I like it, shouldn't be too controversial.

Do you need me to add it as a push request on github?
Xynth@PK
Image
Bunnywabbit
Posts: 965
Joined: Sun May 15, 2005 7:00 am
Location: Amsterdam, the Netherlands

Post by Bunnywabbit »

yes please.
ImageImage current version r158 new beta as of jan 23 2012
Xynth
Posts: 224
Joined: Mon Oct 05, 2009 3:03 pm
Location: St. Louis

Post by Xynth »

Bunnywabbit wrote:QUOTE (Bunnywabbit @ Oct 3 2017, 08:55 AM) yes please.
Done. I asked Cort to review.

https://github.com/FreeAllegiance/Artwork/pull/6
Last edited by Xynth on Wed Oct 04, 2017 4:09 pm, edited 1 time in total.
Xynth@PK
Image
Cortex
Posts: 2578
Joined: Sun Nov 28, 2004 8:00 am
Location: Germany
Contact:

Post by Cortex »

Reviewed PR #6. Had some minor comments, but I think the intention and idea are great!
Image
This is Sparta. Not spa. — Wurf
Image
Post Reply